-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34017/#review84041
-----------------------------------------------------------


Hey Haosdent,
Great job!
I just made 1 little nit-pick, otherwise it looks great!


3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/34017/#comment135172>

    I know you just moved this code, so this is a little nit-pick:
    Can you re-wrap this comment please? We wrap comments at 70 characters, so 
it will now look like:
    
    ```
        item->future->onReady([](const Response& response) {    
          // Cleaning up a response (i.e., closing any open Pipes in the 
          // event Response::type is PIPE).
    ```



3rdparty/libprocess/src/tests/benchmarks.cpp
<https://reviews.apache.org/r/34017/#comment135173>

    Great find ;-)


- Joris Van Remoortere


On May 9, 2015, 7:52 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34017/
> -----------------------------------------------------------
> 
> (Updated May 9, 2015, 7:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2670
>     https://issues.apache.org/jira/browse/MESOS-2670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> According Joris advice, replace the 'lambda::bind' expressions match these 
> rules:
> 
> 1. Binds to a static function without any side-effects.
> 2. Is self contained (i.e. does not rely on contextual parameters)
> 3. Does not bind in any arguments. (i.e. only uses lambda::_N for arguments)
> 4. Is only called in 1 place OR is so small that it is ok to repeat the code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 
> 588bd3e40a0b350ceca15bb8f3f78290ba41d173 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> 0d6714807f7027e6ab199eb0d9ff57bc8a3a2d8a 
> 
> Diff: https://reviews.apache.org/r/34017/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to