> On May 14, 2015, 9:39 a.m., Niklas Nielsen wrote: > > src/examples/test_hook_module.cpp, line 37 > > <https://reviews.apache.org/r/29947/diff/10/?file=958466#file958466line37> > > > > Why did you need this one? > > Kapil Arya wrote: > Without this we would have to use qualify HookExecuted with `internal::`. > (Note that we don't enclose this file in `mesos::internal`).
That's more characters (and two lines more) than qualifying the single use of the message type :) Let's do that instead. I can do it before committing - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/#review83787 ----------------------------------------------------------- On May 13, 2015, 1:36 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29947/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 1:36 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2226 > https://issues.apache.org/jira/browse/MESOS-2226 > > > Repository: mesos > > > Description > ------- > > There is currently no good way to synchronize between the test body and the > hook code, so we wire a promise (owned by the test code). The technical debt > is covered by the following JIRA issue: > > https://issues.apache.org/jira/browse/MESOS-2641 > > > Diffs > ----- > > src/examples/test_hook_module.cpp b25830ab6475f997422cfd2f60cc9a79e1acadfe > src/messages/messages.proto 98d859f3db6013a2e155d838f590a0cde6dc5ed5 > src/tests/hook_tests.cpp a65c0ab7c41ec3b7964f9d572381fa3e61746dc3 > > Diff: https://reviews.apache.org/r/29947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
