-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34388/#review84352
-----------------------------------------------------------

Ship it!


pretty cool!

- Vinod Kone


On May 19, 2015, 5:56 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34388/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 5:56 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2507
>     https://issues.apache.org/jira/browse/MESOS-2507
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The idea here is to index the Slaves by both SlaveID and UPID.
> 
> Boost's multi_index_container provides such functionality, but is potentially 
> overly complicated for what we need here. So I've just added a struct that 
> hides two underlying maps, and added a TODO to weigh multi_index_container vs 
> our own indexing abstraction in stout. We can punt on this until more 
> use-cases show up.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp da0a83510784f4f7dbd933e666ac12c04c413a62 
>   src/master/master.cpp eaea79df2c693d15087d70b3c9b988e57c894f8e 
> 
> Diff: https://reviews.apache.org/r/34388/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to