-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84464
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135756>

    +1



3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135757>

    +1



3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135759>

    I'm not sure what the use case for the case insensitive hash is, but the 
algorithm you use here only works with alpha numeric strings in the ascii ream. 
But what happens with "É" and "é" (ASCII 131 and 142).
    
    BenM approach looks much safer.



3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135760>

    +1 In general avoid printing anything to the console. Nobody actually looks 
at it unless the test fails and in that case we go to the code.


- Alexander Rojas


On May 12, 2015, 2:56 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 2:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test case of extend hashmap to support custom equality and hash
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
> e8a932e5474bf2ba1a93a945ff9bc61fb5146c02 
> 
> Diff: https://reviews.apache.org/r/34068/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to