-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34361/#review84498
-----------------------------------------------------------



src/examples/test_hook_module.cpp
<https://reviews.apache.org/r/34361/#comment135810>

    This constants are used nowhere but in one method. Is there any reason why 
they are not defined in the method itself or at least as static attributes of 
the TestHook class?



src/tests/hook_tests.cpp
<https://reviews.apache.org/r/34361/#comment135811>

    ditto.
    
    Now there are 200 lines between definition and usage. If I am debugging or 
just checking the code, I'll have to scroll all the way up to see the values.



src/tests/master_tests.cpp
<https://reviews.apache.org/r/34361/#comment135812>

    Ditto.
    
    Now 2000 lines between definition and first usage.



src/tests/slave_tests.cpp
<https://reviews.apache.org/r/34361/#comment135813>

    ditto.


- Alexander Rojas


On May 18, 2015, 7:01 p.m., Colin Williams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34361/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 7:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2637
>     https://issues.apache.org/jira/browse/MESOS-2637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> converted hard-coded strings to consts
> 
> 
> Diffs
> -----
> 
>   src/examples/test_hook_module.cpp b25830ab6475f997422cfd2f60cc9a79e1acadfe 
>   src/tests/hook_tests.cpp a65c0ab7c41ec3b7964f9d572381fa3e61746dc3 
>   src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b 
>   src/tests/slave_tests.cpp acae49731ff17103b529cdf828a63d9d55668549 
> 
> Diff: https://reviews.apache.org/r/34361/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Williams
> 
>

Reply via email to