----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84548 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/34319/#comment135862> I don't see why not to use Option here, it's either we have the env or not. We only use Result (not Return) or Try when there is a error message to be propogated but we don't have any here. 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/34319/#comment135863> I don't think we neeed to change this. - Timothy Chen On May 17, 2015, 1:40 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34319/ > ----------------------------------------------------------- > > (Updated May 17, 2015, 1:40 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-994 > https://issues.apache.org/jira/browse/MESOS-994 > > > Repository: mesos > > > Description > ------- > > Refactored os::getenv to return an option and updated os::path accordingly. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > d2ca4be90edb134465751d093b61e84fd6b16f1c > > Diff: https://reviews.apache.org/r/34319/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
