----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/#review84648 -----------------------------------------------------------
Ship it! Thanks for doing it! This was really a pain point :) support/post-reviews.py <https://reviews.apache.org/r/34503/#comment135993> +1 (use of LooseVersion v string comparison) support/post-reviews.py <https://reviews.apache.org/r/34503/#comment135998> not your code - but how would you feel replacing this with a more versatile RegEx match (and using named groups to extract the Review ID)? I can easily create a Jira and fix the code (plus a few other minor fixes) - Marco Massenzio On May 20, 2015, 11:13 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34503/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 11:13 p.m.) > > > Review request for mesos, Cody Maloney, Ian Downes, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Now contributors don't have to manually set the depends on field! > > > Diffs > ----- > > support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 > > Diff: https://reviews.apache.org/r/34503/diff/ > > > Testing > ------- > > Tested with a chain of reviews. > > > Thanks, > > Vinod Kone > >
