----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34559/#review84768 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/34559/#comment136118> Can you add a comment here on why we forward periodically instead of after every update? src/slave/slave.cpp <https://reviews.apache.org/r/34559/#comment136119> instead of a separate function can you copy paste these 2 lines in #3983 and #4094? couple of advantages: only one updateOversubscribableResources() method (which is same as the current _update*) you can chain forwardOversubscribableResources() in #3983 on onAny. i'm assuming there is no point in sending the first forward until the first estimate comes? ``` Slave::_recover() { ... resourceEstimator->oversubscribe() .onAny(defer(self(), &Self::updateOversubscribableResources, lambda::_1)) .onAny(defer(self(), &Self::forwardOversubscribableResources)); ... } Slave::updateOversubscribableResources(const Future<Resources>& future) { ... resourceEstimator->oversubscribe() .onAny(defer(self(), &Self::updateOversubscribableResources)); } ``` - Vinod Kone On May 21, 2015, 7:06 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34559/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 7:06 p.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2735 > https://issues.apache.org/jira/browse/MESOS-2735 > > > Repository: mesos > > > Description > ------- > > Used the pull model to get estimations from resource estimator. > > This reverts the changes made in https://reviews.apache.org/r/34299/. > > > Diffs > ----- > > include/mesos/slave/resource_estimator.hpp > d64c6984f5c0622adde912c6af4857e389171822 > src/slave/resource_estimator.hpp 5a6367c4cf6b840e3ad87a5eb2e758ae441704de > src/slave/resource_estimator.cpp 7b7b49940aeff84a2d0ea3042f5de96f36d67130 > src/slave/slave.hpp d82b10cbd229ce93be8391d4911b6d85c821ccfb > src/slave/slave.cpp 8e88482f41f37ce7f2559fe793565b66ac46fb35 > src/tests/mesos.hpp a60df75350beab8d7091cbe66213ecd920942fa4 > > Diff: https://reviews.apache.org/r/34559/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
