> On April 8, 2015, 7:46 p.m., Ian Downes wrote:
> > src/tests/port_mapping_tests.cpp, lines 2071-2072
> > <https://reviews.apache.org/r/32664/diff/1/?file=911866#file911866line2071>
> >
> >     Why does it need to be random if we're inside a temporary directory 
> > sandbox?

Running in a temporary directory ensures we get a unique namespace without 
having to reason about which applications might be running at any time in a 
container or on the host.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32664/#review79409
-----------------------------------------------------------


On April 1, 2015, 3:45 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32664/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 3:45 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
>     https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add port mapping isolator statistics tests
> 
> 
> Diffs
> -----
> 
>   src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 
> 
> Diff: https://reviews.apache.org/r/32664/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to