> On May 22, 2015, 7:27 a.m., Ian Downes wrote:
> > src/tests/port_mapping_tests.cpp, lines 186-187
> > <https://reviews.apache.org/r/34436/diff/1/?file=966863#file966863line186>
> >
> >     How much noise is there? This seems onerous to users to modify source 
> > and recompile to enable some debug output...

Output goes down from around 160 lines per test to 2 lines.  The advantage of 
removing the output is that you can see the test progress.  The information 
that is output to the screen by default has so far been insufficient to a aid 
in debugging.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34436/#review84884
-----------------------------------------------------------


On May 21, 2015, 11:31 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34436/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 11:31 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2332
>     https://issues.apache.org/jira/browse/MESOS-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Factor out launch helper for easier reuse
> 
> 
> Diffs
> -----
> 
>   src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 
> 
> Diff: https://reviews.apache.org/r/34436/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to