> On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 30 > > <https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line30> > > > > nit: s/correction/corrective action > > > > also, prefer "needs to be taken"
Agree. Also there is gramma mistake in my comment -> s/corrections/correction > On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 42 > > <https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line42> > > > > can you define this instead as: > > > > ``` > > message ActionInfo { > > optional ExecutorID executor_id = 1; > > optional SlaveID slave_id = 2; > > optional TaskID task_id = 3; > > } > > ``` > > or something similar, that makes it more generally applicable? Hey, have you seen the Jie Yu comment in https://reviews.apache.org/r/34571/? That previous request was as an initial work for this issue - please see. Initially we wanted to do it in more generic way. I partly agree with Jie - Offer.Operation is done like that. Aslo notice that SlaveID is not needed here - the corrections are made in Slave scope. Additionaly, we don't want to add unnecessary fields like TaskID for now - if we implement such functionality (killing tasks), then we will add such field - Bartek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review84988 ----------------------------------------------------------- On May 22, 2015, 7:46 p.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34581/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 7:46 p.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod > Kone. > > > Bugs: MESOS-2760 > https://issues.apache.org/jira/browse/MESOS-2760 > > > Repository: mesos > > > Description > ------- > > This proto describes a QoS correction message for particular executor or task. > It is a generic message between QoS Controller and slave. > > Additionaly, updated Makefile to include this proto during compilation. > > This request updates the https://reviews.apache.org/r/34571/ > > > Diffs > ----- > > include/mesos/slave/oversubscription.proto PRE-CREATION > src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 > > Diff: https://reviews.apache.org/r/34581/diff/ > > > Testing > ------- > > * make check > * run mesos: > 1) build (make) > 2) checked that *oversubscription.pb.h* and *oversubscription.pb.cc* are in > the proper directories > 3) run *mesos-slave*, *mesos-master* and checked if their behaviour is proper > > > Thanks, > > Bartek Plotka > >
