> On May 26, 2015, 7:26 p.m., Vinod Kone wrote: > > include/mesos/slave/oversubscription.proto, line 35 > > <https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line35> > > > > s/future/the future/
Agree. > On May 26, 2015, 7:26 p.m., Vinod Kone wrote: > > include/mesos/slave/oversubscription.proto, line 47 > > <https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line47> > > > > why optional? IMO, because we can (only optionally) specify the descriptive reason of some action. Secondly, it's not good idea to limit ourselves with too many required fields - what if we will decide in the future that some actions will have some special type of reasons? (: > On May 26, 2015, 7:26 p.m., Vinod Kone wrote: > > include/mesos/slave/oversubscription.proto, line 48 > > <https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line48> > > > > why a timestamp? It could be necessary for some advanced long term corrective actions (e.g "migrate" or "resize"), when you will have to decide if particular correction is up-to-date. - Bartek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85227 ----------------------------------------------------------- On May 23, 2015, 3:30 a.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34581/ > ----------------------------------------------------------- > > (Updated May 23, 2015, 3:30 a.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod > Kone. > > > Bugs: MESOS-2760 > https://issues.apache.org/jira/browse/MESOS-2760 > > > Repository: mesos > > > Description > ------- > > This proto describes a QoS correction message for particular executor or task. > It is a generic message between QoS Controller and slave. > > Additionaly, updated Makefile to include this proto during compilation. > > This request updates the https://reviews.apache.org/r/34571/ > > > Diffs > ----- > > include/mesos/slave/oversubscription.proto PRE-CREATION > src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 > > Diff: https://reviews.apache.org/r/34581/diff/ > > > Testing > ------- > > * make check > * run mesos: > 1) build (make) > 2) checked that *oversubscription.pb.h* and *oversubscription.pb.cc* are in > the proper directories > 3) run *mesos-slave*, *mesos-master* and checked if their behaviour is proper > > > Thanks, > > Bartek Plotka > >
