----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34676/#review85217 -----------------------------------------------------------
src/common/resources.cpp <https://reviews.apache.org/r/34676/#comment136731> We do 2 blank lines between outer elements. src/common/resources.cpp <https://reviews.apache.org/r/34676/#comment136785> I would recommend putting disk info after role info because people are used to seeing role right after the resource name. i.e., disk(role,principal)[id:hostPath:containerPath] src/common/resources.cpp <https://reviews.apache.org/r/34676/#comment136783> Lets do host_path:container_path instead of the other way around, to be consistent with how docker specifies volumes. See https://github.com/apache/mesos/blob/3baa60965407bf0c3eb9c3da1b2ba7c0a4fee968/src/docker/docker.cpp#L360 src/common/resources.cpp <https://reviews.apache.org/r/34676/#comment136736> Lets use something other than "*", since we already abuse it to represent the default role and unreserved resources. How about "R"? src/tests/resources_tests.cpp <https://reviews.apache.org/r/34676/#comment136733> All comments should be proper sentences/phrases, i.e., start with capital letter and end with period. // Typical resource. Please fix other comments in this test too. src/tests/resources_tests.cpp <https://reviews.apache.org/r/34676/#comment136734> we prefer using proper words for variables. s/oss/stream/ - Vinod Kone On May 26, 2015, 6:32 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34676/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 6:32 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2693 > https://issues.apache.org/jira/browse/MESOS-2693 > > > Repository: mesos > > > Description > ------- > > Add printing of extended attributes to Resource objects. I have no idea what > format is appropriate. I made something that stands some chance of being > parseable in the future. > > > Diffs > ----- > > src/common/resources.cpp d93f38ecdc31605b6a84c8d103ac90e8f0632b01 > src/tests/resources_tests.cpp 459a68bb8e30852becc7d8825a24f984cb027b08 > > Diff: https://reviews.apache.org/r/34676/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Brian Wickman > >
