----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34428/#review85266 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/34428/#comment136800> not yours, but can you fix this whitespace please? src/linux/routing/handle.hpp <https://reviews.apache.org/r/34428/#comment136801> 2 blank lines between outer elements. src/linux/routing/handle.hpp <https://reviews.apache.org/r/34428/#comment136802> 2 blank lines between outer elements. src/linux/routing/queueing/fq_codel.hpp <https://reviews.apache.org/r/34428/#comment136805> s/interface/interface./ src/linux/routing/queueing/internal.hpp <https://reviews.apache.org/r/34428/#comment136806> 2 blank lines. src/linux/routing/queueing/internal.hpp <https://reviews.apache.org/r/34428/#comment136814> s/Name// src/linux/routing/queueing/internal.hpp <https://reviews.apache.org/r/34428/#comment136807> 2 blank lines. src/linux/routing/queueing/internal.hpp <https://reviews.apache.org/r/34428/#comment136810> 3.2.26 of what? the kernel? the libnl? src/linux/routing/queueing/internal.hpp <https://reviews.apache.org/r/34428/#comment136813> s/List// src/linux/routing/queueing/internal.hpp <https://reviews.apache.org/r/34428/#comment136811> 2 blank lines. src/linux/routing/queueing/internal.hpp <https://reviews.apache.org/r/34428/#comment136812> All this information is available to the caller. So just do: return Error("qdisc for the link does not exist"); src/linux/routing/queueing/statistics.cpp <https://reviews.apache.org/r/34428/#comment136808> not in alphabetical order. - Vinod Kone On May 22, 2015, 4:53 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34428/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 4:53 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2750 > https://issues.apache.org/jira/browse/MESOS-2750 > > > Repository: mesos > > > Description > ------- > > Extend queueing discipline wrappers to expose network isolator statistics > > > Diffs > ----- > > src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 > src/linux/routing/handle.hpp PRE-CREATION > src/linux/routing/queueing/fq_codel.hpp > 4f67ab7d64afea96a07dfcf36769a9c667749a00 > src/linux/routing/queueing/fq_codel.cpp > 02ad8df7814c0e549a9ca9aef39777684e6abdcb > src/linux/routing/queueing/ingress.hpp > b323a7f6daed828327d6d9e9740df81582e0ba2b > src/linux/routing/queueing/ingress.cpp > 47c73376097d70819defdee31a6d1e446df6b8ba > src/linux/routing/queueing/internal.hpp > 7c6c4d3d960b9a4bf44dcf482212317522353d69 > src/linux/routing/queueing/statistics.hpp PRE-CREATION > src/linux/routing/queueing/statistics.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34428/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
