> On Feb. 4, 2015, 5:44 p.m., Timothy Chen wrote:
> > src/launcher/executor.cpp, line 137
> > <https://reviews.apache.org/r/30643/diff/1/?file=849116#file849116line137>
> >
> >     I think it's worth commenting somewhere high level that the command 
> > executor is expecting executorInfo's data to be an commandInfo.
> 
> Timothy Chen wrote:
>     also i dont know if this is useful at all besides the mesos-execute case? 
> who else can leverage this change?

This is documented in the executor_info flag help.


> On Feb. 4, 2015, 5:44 p.m., Timothy Chen wrote:
> > src/launcher/executor.cpp, line 130
> > <https://reviews.apache.org/r/30643/diff/1/?file=849116#file849116line130>
> >
> >     They shouldn't both be set as well, I know we check this in the slave, 
> > but I think it's worth mentinoing that we're doing that check else where.

Code removed after rebasing.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30643/#review71122
-----------------------------------------------------------


On May 12, 2015, 5:22 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30643/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 5:22 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Provided executor will be used to run the task rather than deferring to the 
> slave to determine an executor to use (currently the local included command 
> executor).
> 
> This is helpful for testing containers with filesystem isolation as you can 
> fetch an executor into the work directory rather than using the command 
> executor on the host filesystem. You can, of course, still use the command 
> executor, but it will be copied/fetched.
> 
> +tnachen - can you please verify I've preserved the override functionality in 
> the command executor? Is that still required?
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp dbd19e67f56a150f54180ad13e6402842eb68e17 
>   src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 
>   src/launcher/executor.cpp de6f1b104a765a8e53934154e78872b03695b24c 
> 
> Diff: https://reviews.apache.org/r/30643/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> manually used 'mesos execute' and specified command executor, both directly 
> as the value and fetching from file:///. Tested enviroment variables too.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to