-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/#review85274
-----------------------------------------------------------


the nits below are really not so big a deal, but I'd like to see smaller 
patches too..


src/linux/routing/queueing/fq_codel.hpp
<https://reviews.apache.org/r/34426/#comment136822>

    maybe mention the added parameters in the comments? up to you.



src/linux/routing/queueing/fq_codel.hpp
<https://reviews.apache.org/r/34426/#comment136820>

    nit" s/exists/exist/



src/linux/routing/queueing/fq_codel.cpp
<https://reviews.apache.org/r/34426/#comment136824>

    would egress::ROOT be more consistent?



src/linux/routing/queueing/ingress.hpp
<https://reviews.apache.org/r/34426/#comment136827>

    nit: s/handles/handle/



src/linux/routing/queueing/ingress.hpp
<https://reviews.apache.org/r/34426/#comment136828>

    s/exists/exist/



src/linux/routing/queueing/internal.hpp
<https://reviews.apache.org/r/34426/#comment136831>

    update the comment as well?



src/linux/routing/queueing/internal.hpp
<https://reviews.apache.org/r/34426/#comment136834>

    the old way should be the correct style


- Chi Zhang


On May 22, 2015, 4:31 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34426/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 4:31 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2665
>     https://issues.apache.org/jira/browse/MESOS-2665
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Report the network statistics from libnl
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/queueing/fq_codel.hpp 
> 4f67ab7d64afea96a07dfcf36769a9c667749a00 
>   src/linux/routing/queueing/fq_codel.cpp 
> 02ad8df7814c0e549a9ca9aef39777684e6abdcb 
>   src/linux/routing/queueing/ingress.hpp 
> b323a7f6daed828327d6d9e9740df81582e0ba2b 
>   src/linux/routing/queueing/ingress.cpp 
> 47c73376097d70819defdee31a6d1e446df6b8ba 
>   src/linux/routing/queueing/internal.hpp 
> 7c6c4d3d960b9a4bf44dcf482212317522353d69 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 49e983edab598e2ac487bb488fdd12840a9e7dfc 
>   src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 
>   src/tests/routing_tests.cpp 6bf5e63aecf2dee36fb8cf3575c0bd2625d29dfa 
> 
> Diff: https://reviews.apache.org/r/34426/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to