----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/#review85625 -----------------------------------------------------------
Patch looks great! Reviews applied: [34782] All tests passed. - Mesos ReviewBot On May 28, 2015, 8:28 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34782/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 8:28 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2778 > https://issues.apache.org/jira/browse/MESOS-2778 > > > Repository: mesos > > > Description > ------- > > Convert Non-POD static variables in fq_codel and ingress to constexpr > > > Diffs > ----- > > src/linux/routing/handle.hpp 8f2da06207e426e2f2c0a8afa6976778023698c1 > src/linux/routing/queueing/fq_codel.hpp > 02486169a6d337d8b471b05a80e39803b0f1f790 > src/linux/routing/queueing/fq_codel.cpp > f9db58bbd39c1ebfd814ec2d1727e9cc80912762 > src/linux/routing/queueing/ingress.hpp > 4c96b604c7281ec95924c9c996dae6aed548627b > src/linux/routing/queueing/ingress.cpp > fece104648307e97755d5a38123e67c442a70474 > > Diff: https://reviews.apache.org/r/34782/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
