> On May 28, 2015, 12:02 a.m., Niklas Nielsen wrote:
> > src/master/master.cpp, lines 3469-3470
> > <https://reviews.apache.org/r/34730/diff/1/?file=973034#file973034line3469>
> >
> >     Was there some additional math, only to rescind if the estimate is 
> > lower? If not now, should we add a todo?

Now that the slave is no longer periodically sending the updates, I think we 
should just rescind whenever there is an update for simplicity.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34730/#review85468
-----------------------------------------------------------


On May 27, 2015, 11:11 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34730/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 11:11 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2733
>     https://issues.apache.org/jira/browse/MESOS-2733
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is mostly a stub with a metric for the messages. The actual plumbing to 
> the allocator will be sent in a subsequent review.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp c8c6251e8db59c814bc92766df7b05e29d38e97e 
>   src/master/master.cpp 1526f59e7c6b135657550eab2ca46216923a01f6 
>   src/master/metrics.hpp 78d066619a688411550fe9a78811337f3b06abaf 
>   src/master/metrics.cpp ee09664c3c28abb3fdc5e8f2713799ee6a25661b 
>   src/tests/oversubscription_tests.cpp 
> 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 
> 
> Diff: https://reviews.apache.org/r/34730/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to