> On May 28, 2015, 8:21 p.m., Niklas Nielsen wrote: > > src/master/master.cpp, line 3471 > > <https://reviews.apache.org/r/34736/diff/1/?file=973181#file973181line3471> > > > > Do we use semi-colon in log lines? Have mostly seen ':' > > > > Want to add the resources which are now _not_ updated?
we do use semicolons. this was copied from Master::statusUpdate() for example. logged the resources. > On May 28, 2015, 8:21 p.m., Niklas Nielsen wrote: > > src/master/master.cpp, line 3492 > > <https://reviews.apache.org/r/34736/diff/1/?file=973181#file973181line3492> > > > > Did we want to do some math and only rescind when we have to > > (eventually)? as commented on the previous review, i think always rescinding is fine. > On May 28, 2015, 8:21 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 124 > > <https://reviews.apache.org/r/34736/diff/1/?file=973182#file973182line124> > > > > s/opts for/enables/? used 'desires' > On May 28, 2015, 8:21 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, lines 133-134 > > <https://reviews.apache.org/r/34736/diff/1/?file=973182#file973182line133> > > > > Just FYI - after the Resource Estimator patch set. This becomes a typed > > test and we need to rebase this patch. as discussed on IRC, we need a bigger refactor of the test estimator before modularizing the estimator > On May 28, 2015, 8:21 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 149 > > <https://reviews.apache.org/r/34736/diff/1/?file=973182#file973182line149> > > > > I am unclear whether we decided to drop this, as it is implicit or have > > it be explicit. > > > > We should capture it in the style guide, one way or another :) dropping it. > On May 28, 2015, 8:21 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, lines 167-169 > > <https://reviews.apache.org/r/34736/diff/1/?file=973182#file973182line167> > > > > We may have to think a bit over this; with the resource estimator > > change (So we only have access to the interface, not a > > TestResourceEstimator). We won't have the same flexibility. as discussed on IRC, the test estimator would be made mockable. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34736/#review85604 ----------------------------------------------------------- On May 27, 2015, 11:10 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34736/ > ----------------------------------------------------------- > > (Updated May 27, 2015, 11:10 p.m.) > > > Review request for mesos, Jie Yu, Joris Van Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-2733 > https://issues.apache.org/jira/browse/MESOS-2733 > > > Repository: mesos > > > Description > ------- > > Rescinds offers and updates the allocator. > > Note that the offers are not split yet. > > > Diffs > ----- > > src/master/master.cpp 1526f59e7c6b135657550eab2ca46216923a01f6 > src/tests/oversubscription_tests.cpp > 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 > > Diff: https://reviews.apache.org/r/34736/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
