----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34863/#review86063 -----------------------------------------------------------
src/tests/routing_tests.cpp <https://reviews.apache.org/r/34863/#comment137954> already using std::string so drop std:: and then it fits on a single line. src/tests/routing_tests.cpp <https://reviews.apache.org/r/34863/#comment137955> use hashmap::contains(). src/tests/routing_tests.cpp <https://reviews.apache.org/r/34863/#comment137956> ditto src/tests/routing_tests.cpp <https://reviews.apache.org/r/34863/#comment137957> ditto - Ian Downes On May 31, 2015, 1:02 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34863/ > ----------------------------------------------------------- > > (Updated May 31, 2015, 1:02 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2750 > https://issues.apache.org/jira/browse/MESOS-2750 > > > Repository: mesos > > > Description > ------- > > Add tests for new qdisc statistics functions. > > > Diffs > ----- > > src/tests/routing_tests.cpp 2066a56571f43a012992b4294fbf5b6e07c2b159 > > Diff: https://reviews.apache.org/r/34863/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
