----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34899/#review86065 -----------------------------------------------------------
src/linux/routing/queueing/fq_codel.cpp <https://reviews.apache.org/r/34899/#comment137960> what about a static const{expr} char[] variable? src/linux/routing/queueing/ingress.cpp <https://reviews.apache.org/r/34899/#comment137959> ditto - Ian Downes On June 1, 2015, 1:20 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34899/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 1:20 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2792 > https://issues.apache.org/jira/browse/MESOS-2792 > > > Repository: mesos > > > Description > ------- > > Eliminate multiple uses of literal string in fq_codel and ingress queueing > disciplines. > > > Diffs > ----- > > src/linux/routing/queueing/fq_codel.cpp > 64b5c73e8cfa672141ddb663e879c58b4babfdbc > src/linux/routing/queueing/ingress.cpp > ae0c38d2215e7fabcc1060e7385484bd455e1699 > > Diff: https://reviews.apache.org/r/34899/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
