> On June 1, 2015, 8:23 p.m., Ian Downes wrote: > > src/tests/routing_tests.cpp, lines 452-453 > > <https://reviews.apache.org/r/34832/diff/1/?file=974729#file974729line452> > > > > move this up to the ingress::create("noSuchInterface")?
This and following is three tests are there to check that a remove on one filter doesn't fail and remove a similar filter (which would have happened before the latest fix) > On June 1, 2015, 8:23 p.m., Ian Downes wrote: > > src/tests/routing_tests.cpp, lines 496-497 > > <https://reviews.apache.org/r/34832/diff/1/?file=974729#file974729line496> > > > > move this up to the fq_code::create("noSuchInterface")? See comments on ingress. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/#review86061 ----------------------------------------------------------- On May 29, 2015, 10:09 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34832/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 10:09 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2781 > https://issues.apache.org/jira/browse/MESOS-2781 > > > Repository: mesos > > > Description > ------- > > Add new qdisc tests for fq_codel and ingress queueing discipline. > > > Diffs > ----- > > src/tests/routing_tests.cpp 2066a56571f43a012992b4294fbf5b6e07c2b159 > > Diff: https://reviews.apache.org/r/34832/diff/ > > > Testing > ------- > > > Thanks, > > Paul Brett > >
