-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review86088
-----------------------------------------------------------


LGTM


include/mesos/mesos.proto
<https://reviews.apache.org/r/34748/#comment137984>

    kill this :)



include/mesos/mesos.proto
<https://reviews.apache.org/r/34748/#comment137986>

    s/usage of resources/resource usage/


- Niklas Nielsen


On June 1, 2015, 2:26 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 2:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas 
> Nielsen, Szymon Konefal, and Vinod Kone.
> 
> 
> Bugs: MESOS-2772
>     https://issues.apache.org/jira/browse/MESOS-2772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed ResourceMonitor to use ResourceUsage instead of 
> ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
> 
> NOTE: That is required for modules which need to fetch ResourceUsage e.g 
> ResourceEstimator and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and 
> modify, since it's not used anywhere else.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99 
>   src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225 
>   src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e 
> 
> Diff: https://reviews.apache.org/r/34748/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to