-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34944/#review86231
-----------------------------------------------------------

Ship it!


Sweet!

Only comment is that this does not give the client of FlagsBase an option as to 
the behavior of --help (ie, it prints and exit: like it or lump it :).

Which is perfectly fine, IMO, but was wondering whether this was too 
restrictive?
(I haven't seen any other pattern in the 10+ refactorings I've done - so this 
should be just fine)

- Marco Massenzio


On June 2, 2015, 2:46 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34944/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 2:46 p.m.)
> 
> 
> Review request for mesos and Marco Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is one possible way of handling processing --help. Also, this is missing 
> a test.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> 61a405f225d14acbc38a80d35570426cb05a3d0a 
> 
> Diff: https://reviews.apache.org/r/34944/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to