-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review86247
-----------------------------------------------------------

Ship it!



src/examples/test_resource_estimator_module.cpp
<https://reviews.apache.org/r/34662/#comment138171>

    Try<ResourceEstimator*> result = NoopResourceEstimator::create(None());



src/tests/module.hpp
<https://reviews.apache.org/r/34662/#comment138172>

    Do we need this?


- Jie Yu


On June 2, 2015, 12:40 a.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 12:40 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2650
>     https://issues.apache.org/jira/browse/MESOS-2650
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added *ResourceEstimator* (RE) module interface. 
> Added *TestResourceEstimator* example module.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/resource_estimator.hpp PRE-CREATION 
>   src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241 
>   src/examples/test_resource_estimator_module.cpp PRE-CREATION 
>   src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be 
>   src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8 
>   src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29 
> 
> Diff: https://reviews.apache.org/r/34662/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to