----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34984/#review86463 -----------------------------------------------------------
Thanks for taking this on, Aditi! I listed a few suggestions below src/files/files.cpp <https://reviews.apache.org/r/34984/#comment138492> Should be in lexicographical order :) Would you mind sorting these please? src/files/files.cpp <https://reviews.apache.org/r/34984/#comment138494> The alignment seems a bit off, shouldn't be: ``` route("/foobar.json", FooProcess::BAR_HELP, &FooProcess::bar); ``` ? Here and below src/files/files.cpp <https://reviews.apache.org/r/34984/#comment138495> This endpoint supports queries like: /files/browse.json?path=foobar Can you document the query parameters too? Here and below src/files/files.cpp <https://reviews.apache.org/r/34984/#comment138496> Read supports 'path', 'offset' and 'length' query parameters - mind documenting those too? src/files/files.cpp <https://reviews.apache.org/r/34984/#comment138497> This supports the path parameter too, mind documenting it? Thanks! :) - Niklas Nielsen On June 2, 2015, 11:11 p.m., Aditi Dixit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34984/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 11:11 p.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-2277 > https://issues.apache.org/jira/browse/MESOS-2277 > > > Repository: mesos > > > Description > ------- > > Added help for files > > > Diffs > ----- > > src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 > > Diff: https://reviews.apache.org/r/34984/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Aditi Dixit > >
