> On April 8, 2015, 6:44 p.m., Ian Downes wrote: > > src/tests/cgroups_tests.cpp, line 1262 > > <https://reviews.apache.org/r/31012/diff/2/?file=913059#file913059line1262> > > > > Why is this a member variable: it's not used internally by the class.
Setup uses limit now. kept 'limit' and 'allocation' as class member fields, iniatialized by the ctor. > On April 8, 2015, 6:44 p.m., Ian Downes wrote: > > src/tests/cgroups_tests.cpp, line 1237 > > <https://reviews.apache.org/r/31012/diff/2/?file=913059#file913059line1237> > > > > Where does the number 15 come from? it is an arbitrary number below the limit? > On April 8, 2015, 6:44 p.m., Ian Downes wrote: > > src/tests/cgroups_tests.cpp, line 1270 > > <https://reviews.apache.org/r/31012/diff/2/?file=913059#file913059line1270> > > > > Does the test fixture ensure this process is killed? yes. MTH's dtor terminates the subprocess. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31012/#review79387 ----------------------------------------------------------- On June 3, 2015, 10:58 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31012/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 10:58 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: mesos-2572 > https://issues.apache.org/jira/browse/mesos-2572 > > > Repository: mesos > > > Description > ------- > > Added memory statisics test fixure and a test for RSS. > > > Diffs > ----- > > src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a > > Diff: https://reviews.apache.org/r/31012/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
