----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86545 -----------------------------------------------------------
Bad patch! Reviews applied: [34962, 34980] Failed command: ./support/apply-review.sh -n -r 34980 Error: 2015-06-04 03:47:48 URL:https://reviews.apache.org/r/34980/diff/raw/ [5661/5661] -> "34980.patch" [1] error: patch failed: include/mesos/slave/resource_estimator.hpp:25 error: include/mesos/slave/resource_estimator.hpp: patch does not apply error: patch failed: src/slave/resource_estimators/noop.hpp:21 error: src/slave/resource_estimators/noop.hpp: patch does not apply error: patch failed: src/slave/resource_estimators/noop.cpp:59 error: src/slave/resource_estimators/noop.cpp: patch does not apply error: patch failed: src/slave/slave.cpp:323 error: src/slave/slave.cpp: patch does not apply error: patch failed: src/tests/mesos.hpp:715 error: src/tests/mesos.hpp: patch does not apply error: patch failed: src/tests/oversubscription_tests.cpp:87 error: src/tests/oversubscription_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On June 4, 2015, 12:08 a.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34980/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 12:08 a.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod > Kone. > > > Bugs: MESOS-2773 > https://issues.apache.org/jira/browse/MESOS-2773 > > > Repository: mesos > > > Description > ------- > > Pass callback to the resource estimator to retrieve ResourceUsage from > Resource Monitor on demand. > > This is neccessary, since ResourceEstimator needs data (current statistics > for each executor) on which it will base its slack predictions. > > > Diffs > ----- > > include/mesos/slave/resource_estimator.hpp > e7f5decdabdfc75587d784a08a98c62ffdfc2909 > src/slave/resource_estimators/noop.hpp > 2234ed6da17346c74c2e232ff9eae501531515e1 > src/slave/resource_estimators/noop.cpp > 3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 > src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 > src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e > src/tests/oversubscription_tests.cpp > f047b90d8f0b4dfe7e6cad6dc58909451e9f894b > > Diff: https://reviews.apache.org/r/34980/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bartek Plotka > >
