----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35000/#review86787 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/35000/#comment138867> How about starting both enumerations with lower case here to make them part of the same sentence? 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/35000/#comment138868> This leading sentence can exist without the colon and hence the following enumerations could use capitalized sentence starts. I would replace the colon with a period to enable full sentences below. - Till Toenshoff On June 3, 2015, 1:45 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35000/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 1:45 p.m.) > > > Review request for mesos, Bernd Mathiske and Joerg Schad. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > 37cab7755d2890619b64e1ca09e0b7ad0e72cf76 > > Diff: https://reviews.apache.org/r/35000/diff/ > > > Testing > ------- > > make check > doxygen ../Doxyfile > > > Thanks, > > Benjamin Hindman > >
