----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35182/#review86997 -----------------------------------------------------------
Ship it! src/docker/docker.cpp <https://reviews.apache.org/r/35182/#comment139229> You are capturing a temporary by reference here. Make this a plain copy (```Future<string> output```) and pass by value instead ```Future<Docker::Image> Docker::_pull( const Docker& docker, const Subprocess& s, const string& directory, const string& image, const string& path, Future<string> output)``` Then you do not have cast away the constness anymore :) - Till Toenshoff On June 7, 2015, 1:21 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35182/ > ----------------------------------------------------------- > > (Updated June 7, 2015, 1:21 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-2809 > https://issues.apache.org/jira/browse/MESOS-2809 > > > Repository: mesos > > > Description > ------- > > Fix handling large docker image info on inspect. > > > Diffs > ----- > > src/docker/docker.hpp 7790d0ff9a6b085025f595533c5f46b702447927 > src/docker/docker.cpp 71383294c6234d08b2156565b170ada329b8e30f > > Diff: https://reviews.apache.org/r/35182/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
