> On June 8, 2015, 8:44 p.m., Alexander Rojas wrote:
> > src/master/detector.cpp, line 452
> > <https://reviews.apache.org/r/35043/diff/1/?file=978200#file978200line452>
> >
> >     Can you add a line break here.

https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Conditionals


> On June 8, 2015, 8:44 p.m., Alexander Rojas wrote:
> > src/master/detector.cpp, lines 457-458
> > <https://reviews.apache.org/r/35043/diff/1/?file=978200#file978200line457>
> >
> >     I think a line break either before or after the declaration of master 
> > info would look better.

Google Style Guide frowns upon too much "vertical space" - and I do too :)
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Vertical_Whitespace


> On June 8, 2015, 8:44 p.m., Alexander Rojas wrote:
> > src/master/detector.cpp, line 462
> > <https://reviews.apache.org/r/35043/diff/1/?file=978200#file978200line462>
> >
> >     A line break here would look better.

sorry, did you mean a "blank line above" or breaking the `if` and the brace ({)?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35043/#review87079
-----------------------------------------------------------


On June 4, 2015, 4:27 a.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35043/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 4:27 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Joris Van Remoortere, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2340
>     https://issues.apache.org/jira/browse/MESOS-2340
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Jira: MESOS-2340
> 
> The Leader detector will now also try to
> read nodes with label master::MASTER_INFO_JSON_LABEL
> and parse the contents as JSON, converting the data
> to a mesos::MasterInfo protobuf.
> 
> The ability to support binary data in PB format is
> still supported and the master::Contender will continue
> to serialize the binary data, so as to be compatible with
> pre-0.23 Mesos Masters.
> 
> From 0.24 onwards, we will only support JSON data written to ZK.
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp 57cf8fbeff203847b5b5442f6c78ca9c09bcc66d 
>   src/master/constants.cpp 8c7174a9940bd332832bf85d81ab13cf11836dd0 
>   src/master/detector.cpp 5700711771480f4e5da88e60657618c955f10048 
> 
> Diff: https://reviews.apache.org/r/35043/diff/
> 
> 
> Testing
> -------
> 
> make check
> (this is still WIP - need to add unit tests for the new JSON format)
> 
> Also see manual testing results in 
> https://issues.apache.org/jira/browse/MESOS-2340
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Reply via email to