> On June 9, 2015, 10:12 p.m., Niklas Nielsen wrote: > > src/tests/monitor_tests.cpp, line 221 > > <https://reviews.apache.org/r/35264/diff/1/?file=981687#file981687line221> > > > > 77 lines of straight line code; Can we easen up a bit and add structure > > with some comments explaining what's going on and why?
Added comments. > On June 9, 2015, 10:12 p.m., Niklas Nielsen wrote: > > src/tests/monitor_tests.cpp, lines 282-292 > > <https://reviews.apache.org/r/35264/diff/1/?file=981687#file981687line282> > > > > Could you use .contains() instead? We should have landed and deal with > > matching fractions of JSON objects. Good idea! Much cleaner! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/#review87308 ----------------------------------------------------------- On June 9, 2015, 7:51 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35264/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 7:51 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2818 > https://issues.apache.org/jira/browse/MESOS-2818 > > > Repository: mesos > > > Description > ------- > > Added a slave integration test in MonitorTest. > > This test verifies the wiring between resource monitor and the slave. > > > Diffs > ----- > > src/tests/monitor_tests.cpp 6de8b1f65843fd7b852dfa69627a1c435b482fe0 > > Diff: https://reviews.apache.org/r/35264/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
