-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34911/#review87473
-----------------------------------------------------------

Ship it!



src/slave/slave.cpp
<https://reviews.apache.org/r/34911/#comment139798>

    I think we have streaming overload for RepeatedPtrField<Resource>. So get 
rid of the 'Resources' part.



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34911/#comment139804>

    Can you use `createTask` here?
    
    ```
    TaskInfo task = createTask(
        offer2.get()[0].slave_id(),
        taskResources,
        "exit 1",
        exec.id);
    
    task.mutable_executor()->mutable_resources()
      ->CopyFrom(executorResources);
    ```



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34911/#comment139803>

    No need for this. You can directly use initialization list `{task}`.


- Jie Yu


On June 10, 2015, 7:11 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34911/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 7:11 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2753
>     https://issues.apache.org/jira/browse/MESOS-2753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> An end to end test that launches a revocable executor.
> 
> Note that this doesn't exercise cpu isolator because it uses the test 
> containerizer. Cpu isolator with revocable resources is already tested.
> 
> BenM is writing an example framework that should test this with cpu isolator.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 1793b0e16fc36ead147880ee06cda40b23fa0962 
>   src/slave/slave.cpp 98036b2d5f2c765aef4a416c3cbc082df77ab3ac 
>   src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 
>   src/tests/mesos.cpp dff45b0d3bf9ef53f19575ab3d90a0b223755d6a 
>   src/tests/oversubscription_tests.cpp 
> 59cf07ef93460537ce1343793fd4a5d11d2ae242 
> 
> Diff: https://reviews.apache.org/r/34911/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to