-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35327/#review87482
-----------------------------------------------------------

Ship it!



src/common/resources.cpp
<https://reviews.apache.org/r/35327/#comment139815>

    No need for else if.
    
    if () {
    
    }
    
    nameTypes[name] = resource.get().type();



src/common/resources.cpp
<https://reviews.apache.org/r/35327/#comment139816>

    include the offending 'name' in the error?


- Vinod Kone


On June 10, 2015, 10:34 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35327/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 10:34 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2854
>     https://issues.apache.org/jira/browse/MESOS-2854
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp c168bd83d0e0f07fb8f3a70114dd854cad5f5140 
>   src/tests/resources_tests.cpp b1e4483695eda998129db2c89a9dce044607c8b0 
> 
> Diff: https://reviews.apache.org/r/35327/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> Updated test `ResourcesTest.ParseError` to cover this case.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to