-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34687/#review87520
-----------------------------------------------------------
How about adding an 'Address' message, which can contain 'ip' and 'port' for
now?
```
message Address {
required string ip;
required uint32 port;
// Later we can add 'hostname' or 'public_hostname', etc!
}
```
In the future, we can further use this in other protobufs to have a conistent
representation (e.g. SlaveInfo only has 'hostname' and 'port' currently, no
'ip'!). That way, you can add an address to MasterInfo:
```
message MasterInfo {
required string id = 1;
required uint32 ip = 2;
required uint32 port = 3 [default = 5050];
optional string pid = 4;
optional string hostname = 5;
optional Address address = 6;
}
```
This way, you don't need all the custom logic introduced here, and consequently
compatibility is easier to test (i.e. we have already tested our JSON <->
Protobuf conversion facilities).
Have you guys considered this approach?
- Ben Mahler
On June 5, 2015, 8:18 p.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34687/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 8:18 p.m.)
>
>
> Review request for mesos, haosdent huang and Niklas Nielsen.
>
>
> Bugs: MESOS-2807
> https://issues.apache.org/jira/browse/MESOS-2807
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Jira: MESOS-2340
>
> This is a preliminary step to enabling JSON API
> for Master Discovery via Zookeeper.
>
> We currently save the MasterInfo PB to ZK
> serializing directly the binary data, so that
> for clients to retrieve that information, they
> need to either link up with libmesos or
> obtain the PB definition (in mesos/mesos.proto).
>
> This change only provides the (de)serialization
> utility methods and associated tests.
>
>
> Diffs
> -----
>
> src/Makefile.am f2110a360b6e2a1e99e1d9630d5dfacfd818530a
> src/common/http.hpp afce7fea334c7bfa57efc48c413bf906a2ebde32
> src/common/http.cpp 2ac7fba7a3aac913540f1b09768777393b79284a
> src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098
> src/tests/common/http_tests.cpp f087b2313a13c3199b70b3d7feb728e1449a52e7
> src/tests/common/parse_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34687/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Marco Massenzio
>
>
