> On June 10, 2015, 6:32 a.m., Bartek Plotka wrote: > > src/slave/flags.cpp, line 519 > > <https://reviews.apache.org/r/35278/diff/1/?file=981788#file981788line519> > > > > Could you change s/resource estimator/Resource Estimator/ to be > > compliant with "QoS Controller" name? If you are Upper casing names, you > > can do it for RE as well.. (:
Thanks Bartek! I would prefer to go this in a subsequent review (if we agree on it). Let's create a ticket for now, to track it and unify the style. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35278/#review87401 ----------------------------------------------------------- On June 9, 2015, 6:09 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35278/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 6:09 p.m.) > > > Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu. > > > Bugs: MESOS-2703 > https://issues.apache.org/jira/browse/MESOS-2703 > > > Repository: mesos > > > Description > ------- > > Missed this initialization during a rebase during the qos controller patch > set. > > > Diffs > ----- > > src/slave/flags.cpp 99142fb1cf9d1978df86fdbf612e656b8fe852a6 > > Diff: https://reviews.apache.org/r/35278/diff/ > > > Testing > ------- > > make check > > Ran ./bin/mesos-slave.sh --help and confirmed flag appearing. > > > Thanks, > > Niklas Nielsen > >
