> On June 9, 2015, 6:11 p.m., Vinod Kone wrote: > > src/tests/fetcher_cache_tests.cpp, lines 360-361 > > <https://reviews.apache.org/r/35247/diff/1/?file=981340#file981340line360> > > > > Why not just do AWAIT_READY(offers)? > > Bernd Mathiske wrote: > That does not compile here, because it contains a "return" of type void > and that does not match the return type of "launch()". > > Vinod Kone wrote: > aah. ok.
Well, you can return a Try in this helper function and ASSERT on that in each test? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35247/#review87235 ----------------------------------------------------------- On June 9, 2015, 9:32 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35247/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 9:32 a.m.) > > > Review request for mesos, Benjamin Hindman, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-2815, MESOS-2829 and MESOS-2831 > https://issues.apache.org/jira/browse/MESOS-2815 > https://issues.apache.org/jira/browse/MESOS-2829 > https://issues.apache.org/jira/browse/MESOS-2831 > > > Repository: mesos > > > Description > ------- > > Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in > fetcher_cache_tests.cpp. > > Installed a default response that provides teporary cover for this mocked > method until we install more interesting callbacks later. This prevents gmock > from complaining about an "uninteresting gmock call", which led to a variety > of tests failing due to offers not getting through subsequently. > > All fetcher cache tests have been affected by this race and should be fixed > in this regard now. > > (Also fixed some typos.) > > > Diffs > ----- > > src/tests/fetcher_cache_tests.cpp cbd44b98d19953d174fac977f509d4900a37481f > > Diff: https://reviews.apache.org/r/35247/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
