> On June 11, 2015, 10:02 a.m., Adam B wrote:
> > docs/getting-started.md, line 39
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line39>
> >
> >     What about these python packages? Probably still necessary if you don't 
> > `configure --disable-python`.

they are there - a few lines below


> On June 11, 2015, 10:02 a.m., Adam B wrote:
> > docs/getting-started.md, line 41
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line41>
> >
> >     0.21 and newer? (sasl is 0.14+, maven is 0.18+) Otherwise why call out 
> > the version at all, if you're just going to recommend they install the 
> > latest?

because this is the version I tested them with - I have no idea if this works 
with anything older
also, this is what it was used before


> On June 11, 2015, 10:02 a.m., Adam B wrote:
> > docs/getting-started.md, line 51
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line51>
> >
> >     Can you get a Mac user to review/approve these instructions? Maybe 
> > @davelester or @nnielsen

I tested it on a Mac - and they worked
I would argue that this is better than nothing at all?


> On June 11, 2015, 10:02 a.m., Adam B wrote:
> > docs/getting-started.md, line 109
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line109>
> >
> >     Probably better to recommend j=<number of cores> or j=<#GB RAM>, since 
> > j=8 could be overkill on a dual-core or smaller.

Good suggestion!
will do


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87539
-----------------------------------------------------------


On June 3, 2015, 6:44 a.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 6:44 a.m.)
> 
> 
> Review request for mesos and Dave Lester.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added installation instructions for Ubuntu 14.04 and OSX
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75 
> 
> Diff: https://reviews.apache.org/r/34976/diff/
> 
> 
> Testing
> -------
> 
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu 
> box.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Reply via email to