-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14460/#review87786
-----------------------------------------------------------


Bad patch!

Reviews applied: [14460]

Failed command: ./support/apply-review.sh -n -r 14460

Error:
 2015-06-12 23:41:56 URL:https://reviews.apache.org/r/14460/diff/raw/ 
[13258/13258] -> "14460.patch" [1]
14460.patch:35: trailing whitespace.
Build-Depends: 
14460.patch:36: trailing whitespace.
 debhelper (>= 8.0.0), 
14460.patch:37: trailing whitespace.
 libunwind7|libunwind8, 
14460.patch:38: trailing whitespace.
 java7-jdk|java6-sdk, 
14460.patch:39: trailing whitespace.
 python-all-dev (>= 2.6), 
warning: squelched 17 whitespace errors
warning: 22 lines add whitespace errors.
Successfully applied: Add debian directory to create mesos packages

This patch create the debian directory with multipackage configuration
  * libmesos (shared library)
  * libmesos-dev (hpp files)
  * python-mesos (python mesos bindings)
  * mesos-common (common binaries and directories)
  * mesos-master (master service + web interface)
  * mesos-slave (slave service)

Services are sysvinit based (not upstart) inspired from @deric work 
https://github.com/deric/mesos-deb-packaging

I tried to fit as much as possible to debian guidelines
I took some parts from Daniel Lundin ( @dln ) work like descriptions and some 
splitting of the packages (cf 
https://github.com/dln/mesos/tree/debian-package-0.14.0-rc3)

To build packages just run (need devscripts package)
```
debuild -b -us -uc
```


Review: https://reviews.apache.org/r/14460
debian/control:5: trailing whitespace.
+Build-Depends: 
debian/control:6: trailing whitespace.
+ debhelper (>= 8.0.0), 
debian/control:7: trailing whitespace.
+ libunwind7|libunwind8, 
debian/control:8: trailing whitespace.
+ java7-jdk|java6-sdk, 
debian/control:9: trailing whitespace.
+ python-all-dev (>= 2.6), 
debian/control:10: trailing whitespace.
+ libcurl3-dev, 
debian/control:11: trailing whitespace.
+ autoconf, 
debian/control:12: trailing whitespace.
+ libtool, 
debian/control:13: trailing whitespace.
+ dh-autoreconf, 
debian/control:14: trailing whitespace.
+ python-setuptools, 
debian/control:15: trailing whitespace.
+ python-protobuf (>= 2.4.1), 
debian/control:16: trailing whitespace.
+ chrpath, 
debian/control:52: trailing whitespace.
+Depends: 
debian/control:54: trailing whitespace.
+ ${shlibs:Depends}, 
debian/control:80: trailing whitespace.
+ libmesos (= ${binary:Version}), 
debian/control:81: trailing whitespace.
+ python-protobuf (>= 2.4.1), 
debian/control:82: trailing whitespace.
+ ${python:Depends}, 
debian/control:83: trailing whitespace.
+ ${misc:Depends}, 
debian/control:104: new blank line at EOF.
debian/mesos-master.init:75: new blank line at EOF.
debian/mesos-slave.default:13: new blank line at EOF.
debian/mesos-slave.init:73: new blank line at EOF.
Failed to commit patch

- Mesos ReviewBot


On Oct. 4, 2013, 7:50 a.m., Damien Hardy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14460/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 7:50 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-74
>     https://issues.apache.org/jira/browse/MESOS-74
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> This patch create the debian directory with multipackage configuration
>   * libmesos (shared library)
>   * libmesos-dev (hpp files)
>   * python-mesos (python mesos bindings)
>   * mesos-common (common binaries and directories)
>   * mesos-master (master service + web interface)
>   * mesos-slave (slave service)
> 
> Services are sysvinit based (not upstart) inspired from @deric work 
> https://github.com/deric/mesos-deb-packaging
> 
> I tried to fit as much as possible to debian guidelines
> I took some parts from Daniel Lundin ( @dln ) work like descriptions and some 
> splitting of the packages (cf 
> https://github.com/dln/mesos/tree/debian-package-0.14.0-rc3)
> 
> To build packages just run (need devscripts package)
> ```
> debuild -b -us -uc
> ```
> 
> 
> Diffs
> -----
> 
>   debian/changelog PRE-CREATION 
>   debian/compat PRE-CREATION 
>   debian/control PRE-CREATION 
>   debian/copyright PRE-CREATION 
>   debian/dirs PRE-CREATION 
>   debian/docs PRE-CREATION 
>   debian/libmesos-dev.install PRE-CREATION 
>   debian/libmesos.install PRE-CREATION 
>   debian/mesos-common.install PRE-CREATION 
>   debian/mesos-master.default PRE-CREATION 
>   debian/mesos-master.init PRE-CREATION 
>   debian/mesos-master.install PRE-CREATION 
>   debian/mesos-slave.default PRE-CREATION 
>   debian/mesos-slave.init PRE-CREATION 
>   debian/mesos-slave.install PRE-CREATION 
>   debian/python-mesos.install PRE-CREATION 
>   debian/rules PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14460/diff/
> 
> 
> Testing
> -------
> 
> tested with mesos HEAD (today) on debian squeeze. 
> requirement :
>   * python-protobuf 2.4.1 deb generated with 
> https://github.com/jordansissel/fpm
>   * add path to libjvm.so (java shared lib) in ldconfig conf ( ex : 
> /etc/ld.so.conf.d/java.conf ) or in env $LD_LIBRARY_PATH PATH so that 
> binaries can without static linking to some specific JVM
>     if you installed openjdk-6-jre-headless it is 
> /usr/lib/jvm/java-6-openjdk/jre/lib/amd64/server to be added
> 
> 
> Thanks,
> 
> Damien Hardy
> 
>

Reply via email to