----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review87802 -----------------------------------------------------------
src/docker/docker.cpp <https://reviews.apache.org/r/35330/#comment140245> This can fit 80 line width? src/docker/docker.cpp <https://reviews.apache.org/r/35330/#comment140246> this too? src/docker/docker.cpp <https://reviews.apache.org/r/35330/#comment140247> Fix 80 line width? src/docker/docker.cpp <https://reviews.apache.org/r/35330/#comment140248> I think you can use pop_front here to be more obvious src/docker/docker.cpp <https://reviews.apache.org/r/35330/#comment140249> How about merging this conditions together since they do the exact same thing? prefix.isNone() || strings::startsWith(name, prefix.get()) - Timothy Chen On June 11, 2015, 9:39 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35330/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 9:39 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2797 > https://issues.apache.org/jira/browse/MESOS-2797 > > > Repository: mesos > > > Description > ------- > > Capped number of parallel inspect instances on a docker ps call. > > > Diffs > ----- > > src/docker/docker.hpp 7790d0ff9a6b085025f595533c5f46b702447927 > src/docker/docker.cpp 71383294c6234d08b2156565b170ada329b8e30f > src/slave/constants.hpp 84927e589499e989249c217db571bbeb84a88af1 > > Diff: https://reviews.apache.org/r/35330/diff/ > > > Testing > ------- > > sudo ./mesos-tests.sh --gtest_filter="*DOCKER*" --gtest_break_on_failure > --gtest_shuffle --gtest_repeat=30 > > > Thanks, > > Lily Chen > >
