-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35426/#review87832
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On June 13, 2015, 2:07 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35426/
> -----------------------------------------------------------
> 
> (Updated June 13, 2015, 2:07 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `grep -r "CHECK([^!].*.isNone())" .` to find the instances that look 
> like `CHECK(x.isNone());`
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp a3d27dc0675221fdeab8ab57e053e98fbc6fccbd 
>   src/linux/cgroups.cpp a612fab2d25516be0981822658bef2d0b90488f0 
>   src/master/registrar.cpp 3fde8fa3ed3b412fa48542c001d86efdd0a9768a 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> 5bd352549553fc0caf62bf116deb5cece35679c6 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 7fb6c8ab69ea64aadc81f2b0e4c769d5305107e3 
>   src/slave/status_update_manager.cpp 
> 1d7c4d09cd530e03c47c0cffca336ea2104b0bcf 
>   src/state/leveldb.cpp 4303df3849a2023cfddaf9cf741ffefe6aada528 
>   src/state/zookeeper.cpp d355bd7ea39a69e4a248f03b776067e5da49e0e3 
>   src/zookeeper/contender.cpp 55cb7a14542e5344148106e196f8c4470496a542 
>   src/zookeeper/group.cpp 173caa859d8566318a1a832a8b763405ce41afc1 
> 
> Diff: https://reviews.apache.org/r/35426/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to