-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35438/#review87895
-----------------------------------------------------------



src/tests/fetcher_cache_tests.cpp
<https://reviews.apache.org/r/35438/#comment140309>

    Does this mean when the default changes we need to change this value too?
    
    Also what's the rationale making it a Error/Try? Is this because a timeout 
can be a valid case here?


- Timothy Chen


On June 14, 2015, 1:54 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35438/
> -----------------------------------------------------------
> 
> (Updated June 14, 2015, 1:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow up to RR https://reviews.apache.org/r/35247/, which was not good 
> enough, fixed only one of two problems.
> 
> Using DeclineOffers() instead of Return() should make the master resend 
> offers so we can launch tasks. See line 205 below.
> 
> Following Jie's suggestion, no more CHECK_READY inside launchTask(s)(), but 
> we return a Try instead and follow call sites with EXPECT_SOME(task(s)).
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 8bd5dd847fb189d0eeeaa760d3ec8ce3af1c2392 
> 
> Diff: https://reviews.apache.org/r/35438/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Reply via email to