----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35411/#review87968 -----------------------------------------------------------
Just wanted to tag on this review and follow the update changes - LGTM :) src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/35411/#comment140373> Which kind of update message? :) s/update/'SlaveUpdate'/ ? src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/35411/#comment140375> You have the PIDs of the master and slave - would it make sense to be explicit in the pattern matching? src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/35411/#comment140374> Should we const 'resources'? - Niklas Nielsen On June 15, 2015, 10:59 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35411/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 10:59 a.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2866 > https://issues.apache.org/jira/browse/MESOS-2866 > > > Repository: mesos > > > Description > ------- > > Send oversubscribable resources during (re-)registration. > > > Diffs > ----- > > src/slave/slave.hpp 0df1b55791963fb4159b7ea5318d09dde4f7d8c7 > src/slave/slave.cpp b523c2fce50e56f4f94d55a9488f49c53452e4d4 > src/tests/oversubscription_tests.cpp > e8ae053dd9cd712e49bd2830e414b7a3d99c20ca > > Diff: https://reviews.apache.org/r/35411/diff/ > > > Testing > ------- > > > Thanks, > > Ben Mahler > >
