----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35473/#review87975 -----------------------------------------------------------
src/master/allocator/sorter/drf/sorter.cpp <https://reviews.apache.org/r/35473/#comment140386> How about the same logic in both? ``` { if (_resources.empty()) { // Do work. } } ``` In the case of remove(), we can have a CHECK that the slave id is contained in the map as part of the work? - Ben Mahler On June 15, 2015, 9:15 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35473/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 9:15 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2627 > https://issues.apache.org/jira/browse/MESOS-2627 > > > Repository: mesos > > > Description > ------- > > Removed a few incorrect CHECKs in DRF sorter. > > See details in the ticket for the reason why this is needed. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.cpp > ac05afdc7d408735dd796faa68c943e75540aaa7 > > Diff: https://reviews.apache.org/r/35473/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
