> On June 15, 2015, 9:50 p.m., Cody Maloney wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 50 > > <https://reviews.apache.org/r/35179/diff/6/?file=984730#file984730line50> > > > > Looks like there is an accidental space addded after path1 here
My bad, Fixed. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/#review87978 ----------------------------------------------------------- On June 15, 2015, 10:45 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35179/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 10:45 p.m.) > > > Review request for mesos, Adam B and Cody Maloney. > > > Bugs: MESOS-1733 > https://issues.apache.org/jira/browse/MESOS-1733 > > > Repository: mesos > > > Description > ------- > > This change takes an un-complicated/naive route ( no trimming of values etc ) > at making path::join(...) variadic mainly in order to preserve the earlier > over-loaded join functionality. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > d4df6502d1297ea3ad8e2a1e3bb16ea9d7c7913c > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp > cf354125687e0f60b6d5b105f19d75e4436f21bf > > Diff: https://reviews.apache.org/r/35179/diff/ > > > Testing > ------- > > make check + added some additional tests. > > > Thanks, > > Anand Mazumdar > >
