----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35508/#review88101 -----------------------------------------------------------
Ship it! It looks like this was probably the original intent (doesn't look like the author realized that 'print' already adds a newline). Looks clearer to me having tried this out locally. Unless more folks object I'll get this committed for you. - Ben Mahler On June 16, 2015, 4:58 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35508/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 4:58 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Section titles now append to the section they lead instead of the one above, > i.e. currently it prints the output like this: > > ``` > Running 'rbt post' across all of ... > 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD -> > alexander/quickfix/post-review-spacing) Improve readability in post-review > (46 seconds ago) > Creating diff of: > > 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD -> > alexander/quickfix/post-review-spacing) Improve readability in post-review > ... with parent diff created from: > > b5eea1750953671fcd25963e5c5660ff40ca27f1 - Added stream manipulators for the > Time object. (2 minutes ago) > Press enter to continue or 'Ctrl-C' to skip. > ``` > > Note how the string *Creating diff of:* is the next line after the previous > section, but it has one line separation to the following; the same holds for > the string *... with parent diff created from*. The proposed change will > produce the output: > > ``` > Running 'rbt post' across all of ... > 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD -> > alexander/quickfix/post-review-spacing) Improve readability in post-review > (46 seconds ago) > > Creating diff of: > 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD -> > alexander/quickfix/post-review-spacing) Improve readability in post-review > > ... with parent diff created from: > b5eea1750953671fcd25963e5c5660ff40ca27f1 - Added stream manipulators for the > Time object. (2 minutes ago) > Press enter to continue or 'Ctrl-C' to skip. > ``` > > Where sections are consistent with their contents. > > > Diffs > ----- > > support/post-reviews.py ba016f5a12f438e4748ded48d5c0b96facf173cf > > Diff: https://reviews.apache.org/r/35508/diff/ > > > Testing > ------- > > manual testing. > > > Thanks, > > Alexander Rojas > >
