-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35536/#review88145
-----------------------------------------------------------

Ship it!


Great cleanup! Thanks Paul!


src/slave/containerizer/isolators/network/port_mapping.cpp (lines 2768 - 2769)
<https://reviews.apache.org/r/35536/#comment140549>

    Not yours, but can you fix the format:
    ```
    return Failure(
        "Failed to ... "
        "network statistics: " + object.error());
    ```



src/slave/containerizer/isolators/network/port_mapping.cpp (line 2772)
<https://reviews.apache.org/r/35536/#comment140551>

    s/isolatorStats/statistics/



src/slave/containerizer/isolators/network/port_mapping.cpp (lines 2775 - 2776)
<https://reviews.apache.org/r/35536/#comment140550>

    Ditto.


- Jie Yu


On June 16, 2015, 8:27 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35536/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 8:27 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2874
>     https://issues.apache.org/jira/browse/MESOS-2874
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace adhoc JSON conversion functions for ResourceStatistics with a 
> protocol buffer to JSON converter.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 4c719b186b519fad0c3869dbdae8b60c3a2c20cc 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 432b05ce5a99c8239fafc47a6b65d46a0fbac26e 
>   src/tests/port_mapping_tests.cpp f8372df74cd71df37de4a2438069ef0ea8878512 
> 
> Diff: https://reviews.apache.org/r/35536/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to