> On June 16, 2015, 2:31 p.m., Jie Yu wrote: > > src/tests/mesos.hpp, line 205 > > <https://reviews.apache.org/r/34721/diff/7/?file=985951#file985951line205> > > > > Can you instead add a overload for qosController only (similar to what > > we did for resourceEstimator above)?
Done > On June 16, 2015, 2:31 p.m., Jie Yu wrote: > > src/tests/oversubscription_tests.cpp, lines 827-834 > > <https://reviews.apache.org/r/34721/diff/7/?file=985953#file985953line827> > > > > can you use 'createTask' to construct the task? See examples in this > > file. Great suggestion! Should be in now > On June 16, 2015, 2:31 p.m., Jie Yu wrote: > > src/tests/oversubscription_tests.cpp, lines 859-861 > > <https://reviews.apache.org/r/34721/diff/7/?file=985953#file985953line859> > > > > Use initialization list please:) Good point - looks much better now - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review88128 ----------------------------------------------------------- On June 16, 2015, 1:43 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34721/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 1:43 p.m.) > > > Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and > Vinod Kone. > > > Bugs: MESOS-2653 > https://issues.apache.org/jira/browse/MESOS-2653 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 > src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 > src/tests/oversubscription_tests.cpp > 3481ad2eef43c3860642970b4c96494997de8552 > > Diff: https://reviews.apache.org/r/34721/diff/ > > > Testing > ------- > > make check (with new qos test) > > > Thanks, > > Niklas Nielsen > >
