> On June 18, 2015, 3:17 a.m., Michael Park wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 135 > > <https://reviews.apache.org/r/35544/diff/1/?file=986152#file986152line135> > > > > While your analysis is correct, we need to use `get` here instead since > > `at` will throw an exception if the element is not found.
I see, we're relying on `contains` above to make sure the `at` doesn't throw here... - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35544/#review88329 ----------------------------------------------------------- On June 17, 2015, 12:13 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35544/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 12:13 a.m.) > > > Review request for mesos and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Replaced dynamic hashmap creation with c++11's static initialization. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 8c102fb7d1f79ee768cb06de3a976ea12f958712 > > Diff: https://reviews.apache.org/r/35544/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
