> On June 18, 2015, 1:01 a.m., Till Toenshoff wrote:
> > src/tests/containerizer.cpp, line 124
> > <https://reviews.apache.org/r/35566/diff/1/?file=986478#file986478line124>
> >
> >     This indention will very soon not comply with our styleguide anymore, 
> > no?

No, it will, we still wrap the same way for 'for' and 'foreach*'.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35566/#review88320
-----------------------------------------------------------


On June 17, 2015, 2:28 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35566/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 2:28 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-2832
>     https://issues.apache.org/jira/browse/MESOS-2832
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp 
> 0b67d1bdf157b2db927699f44fa8210bacb76701 
>   src/slave/containerizer/containerizer.cpp 
> e995ce602261c18373ac09c823638c4a252cca86 
>   src/slave/containerizer/docker.hpp 395d5352ad70ed4b7f954d82b1b93e18ca4b74e5 
>   src/slave/containerizer/docker.cpp 00db9811824995fe19a6143aa2bcba3733a93147 
>   src/slave/containerizer/external_containerizer.cpp 
> 33fc010393e1e664c3b50d849284b14275b29377 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 8c102fb7d1f79ee768cb06de3a976ea12f958712 
>   src/tests/containerizer.cpp 80b910515694c81cf5b1eace1d79a5178cf35426 
> 
> Diff: https://reviews.apache.org/r/35566/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to